From 6e0341c6356cdb6e527fbd89d1dc876f4e47ce46 Mon Sep 17 00:00:00 2001
From: chenluhua1980 <Chenluhua@qq.com>
Date: 星期五, 09 一月 2026 20:37:50 +0800
Subject: [PATCH] 1.Trace Data,ProcessData, SVData等上报

---
 SourceCode/Bond/Servo/HsmsPassive.cpp |  323 +++++++++++++++++++++++++++++++++++++++++++++++++----
 1 files changed, 295 insertions(+), 28 deletions(-)

diff --git a/SourceCode/Bond/Servo/HsmsPassive.cpp b/SourceCode/Bond/Servo/HsmsPassive.cpp
index da6e106..d35b5b8 100644
--- a/SourceCode/Bond/Servo/HsmsPassive.cpp
+++ b/SourceCode/Bond/Servo/HsmsPassive.cpp
@@ -12,10 +12,26 @@
 #include <set>
 #include <regex>
 
+// ControlState values (keep in sync with Model::ControlState / VariableList.txt)
+static constexpr uint8_t kControlStateOnlineRemote = 5;
+
 
 const char ACK[2] = {0, 1};
 const char* ACK0 = &ACK[0];
 const char* ACK1 = &ACK[1];
+
+// Log SECS-II message briefly to avoid huge strings causing issues.
+static void LogSecsMessageBrief(const char* tag, IMessage* pMessage, size_t maxLen = 1024)
+{
+	if (pMessage == nullptr) return;
+	const char* msgStr = pMessage->toString();
+	if (msgStr == nullptr) return;
+	std::string buf(msgStr);
+	if (buf.size() > maxLen) {
+		buf = buf.substr(0, maxLen) + "...<truncated>";
+	}
+	LOGI("%s%s", tag, buf.c_str());
+}
 
 unsigned __stdcall CimWorkThreadFunction(LPVOID lpParam)
 {
@@ -110,23 +126,35 @@
 	ASSERT(pParent);
 	ASSERT(pVariable);
 
+	std::string svNote("SV");
+	{
+		SERVO::CVariable* pDef = getVariable((int)pVariable->getVarialbleId());
+		if (pDef == nullptr) {
+			pDef = pVariable;
+		}
+		auto& name = pDef->getName();
+		if (!name.empty()) {
+			svNote += " -> ";
+			svNote += name;
+		}
+	}
 
 	ISECS2Item* pItemList;
 	SERVO::SVFromat format = pVariable->getFormat();
 	switch (format)
 	{
 	case SERVO::SVFromat::U1:
-		pParent->addU1Item((unsigned char)pVariable->getIntValue(), "SV");
+		pParent->addU1Item((unsigned char)pVariable->getIntValue(), svNote.c_str());
 		break;
 	case SERVO::SVFromat::U2:
-		pParent->addU2Item((unsigned char)pVariable->getIntValue(), "SV");
+		pParent->addU2Item((unsigned char)pVariable->getIntValue(), svNote.c_str());
 		break;
 	case SERVO::SVFromat::I2:
-		pParent->addI2Item((unsigned char)pVariable->getIntValue(), "SV");
+		pParent->addI2Item((unsigned char)pVariable->getIntValue(), svNote.c_str());
 		break;
 	case SERVO::SVFromat::A20:
 	case SERVO::SVFromat::A50:
-		pParent->addItem(pVariable->getValue().c_str(), "SV");
+		pParent->addItem(pVariable->getValue().c_str(), svNote.c_str());
 		break;
 	case SERVO::SVFromat::L:
 		pItemList = pParent->addItem();
@@ -432,6 +460,21 @@
 	return nullptr;
 }
 
+int CHsmsPassive::getCurrentControlState()
+{
+	auto v = getVariable("CurrentControlState");
+	if (v != nullptr) {
+		return static_cast<int>(v->getIntValue());
+	}
+	return 0;
+}
+
+bool CHsmsPassive::isHostCommandAllowed()
+{
+	// Only allow host control commands in OnlineRemote.
+	return getCurrentControlState() == kControlStateOnlineRemote;
+}
+
 void CHsmsPassive::clearAllVariabel()
 {
 	for (auto item : m_variabels) {
@@ -495,26 +538,37 @@
 
 void CHsmsPassive::setVariableValue(const char* pszName, __int64 value)
 {
-	auto v = getVariable(pszName);
-	if (v != nullptr) {
+	// Protect variable list updates; multiple threads may set SVs.
+	Lock();
+	if (auto v = getVariable(pszName)) {
 		v->setValue(value);
 	}
+	Unlock();
 }
 
 void CHsmsPassive::setVariableValue(const char* pszName, const char* value)
 {
-	auto v = getVariable(pszName);
-	if (v != nullptr) {
+	Lock();
+	if (auto v = getVariable(pszName)) {
 		v->setValue(value);
 	}
+	Unlock();
 }
 
 void CHsmsPassive::setVariableValue(const char* pszName, std::vector<SERVO::CVariable>& vars)
 {
-	auto v = getVariable(pszName);
-	if (v != nullptr) {
+	Lock();
+	if (auto v = getVariable(pszName)) {
 		v->setValue(vars);
 	}
+	Unlock();
+}
+
+void CHsmsPassive::withVariableLock(const std::function<void()>& fn)
+{
+	Lock();
+	if (fn) fn();
+	Unlock();
 }
 
 static bool isValidFormat(const std::string& fmt)
@@ -1257,13 +1311,19 @@
 		HEADER* pHeader = pMessage->getHeader();
 		int nStream = (pHeader->stream & 0x7F);
 
-		LOGI("<HSMS>[Received]%s", pMessage->toString());
+		LogSecsMessageBrief("<HSMS>[Received]", pMessage);
 		if (nStream == 1 && pHeader->function == 1) {
 			// S1F1
 			replyAreYouThere(pMessage);
 		}
 		else if (nStream == 1 && pHeader->function == 3) {
 			replySelectedEquipmentStatusData(pMessage);
+		}
+		else if (nStream == 1 && pHeader->function == 11) {
+			replyStatusVariableNamelistRequest(pMessage);
+		}
+		else if (nStream == 1 && pHeader->function == 23) {
+			replyCollectionEventNamelistRequest(pMessage);
 		}
 		else if (nStream == 1 && pHeader->function == 13) {
 			replyEstablishCommunications(pMessage);
@@ -1590,7 +1650,8 @@
 
 				ASSERT(pMessage);
 				m_pPassive->sendMessage(pMessage);
-				LOGI("<HSMS> [SEND] SysByte=%u sessionId:%d", pMessage->getHeader()->systemBytes, pMessage->getHeader()->sessionId);
+				LOGI("<HSMS>[SEND]SysByte=%u sessionId:%d", pMessage->getHeader()->systemBytes, pMessage->getHeader()->sessionId);
+				LogSecsMessageBrief("<HSMS>[SEND]", pMessage);
 
 				int nRet = WaitForSingleObject(pAction->getEvent(), pAction->getTimeout() * 1000);
 				if (nRet == WAIT_TIMEOUT) {
@@ -1615,7 +1676,8 @@
 
 				ASSERT(pMessage);
 				m_pPassive->sendMessage(pMessage);
-				LOGI("<HSMS> [SEND] SysByte=%u sessionId:%d", pMessage->getHeader()->systemBytes, pMessage->getHeader()->sessionId);
+				LOGI("<HSMS>[SEND]SysByte=%u sessionId:%d", pMessage->getHeader()->systemBytes, pMessage->getHeader()->sessionId);
+				LogSecsMessageBrief("<HSMS>[SEND]", pMessage);
 
 			}
 		}
@@ -1639,7 +1701,7 @@
 	m_pPassive->sendMessage(pMessage);
 	LOGI("<HSMS>[SEND]sessionId:%d, sType:%d systemBytes:%d",
 		pMessage->getHeader()->sessionId, pMessage->getHeader()->sType, pMessage->getHeader()->systemBytes);
-	LOGI("<HSMS>[SEND]%s", pMessage->toString());
+	LogSecsMessageBrief("<HSMS>[SEND]", pMessage);
 	HSMS_Destroy1Message(pMessage);
 }
 
@@ -1682,7 +1744,7 @@
 	m_pPassive->sendMessage(pMessage);
 	LOGI("<HSMS>[SEND]sessionId:%d, sType:%d systemBytes:%d",
 		pMessage->getHeader()->sessionId, pMessage->getHeader()->sType, pMessage->getHeader()->systemBytes);
-	LOGI("<HSMS>[SEND]%s", pMessage->toString());
+	LogSecsMessageBrief("<HSMS>[SEND]", pMessage);
 	HSMS_Destroy1Message(pMessage);
 
 	return 0;
@@ -1745,7 +1807,7 @@
 	m_pPassive->sendMessage(pMessage);
 	LOGI("<HSMS>[SEND]sessionId:%d, sType:%d systemBytes:%d",
 		pMessage->getHeader()->sessionId, pMessage->getHeader()->sType, pMessage->getHeader()->systemBytes);
-	LOGI("<HSMS>[SEND]%s", pMessage->toString());
+	LogSecsMessageBrief("<HSMS>[SEND]", pMessage);
 	HSMS_Destroy1Message(pMessage);
 
 	return 0;
@@ -1770,8 +1832,15 @@
 		goto MYREPLY;
 	}
 	if (!pBody->getSubItemU2(0, SVID)) {
-		pMessage->getBody()->addU1Item(SVU1, "SV");
-		goto MYREPLY;
+		// also accept I2 or U4 to be tolerant with host implementations
+		if (!pBody->getSubItemI2(0, (short&)SVID)) {
+			unsigned int svidU4 = 0;
+			if (!pBody->getSubItemU4(0, svidU4)) {
+				pMessage->getBody()->addU1Item(SVU1, "SV");
+				goto MYREPLY;
+			}
+			SVID = static_cast<unsigned short>(svidU4);
+		}
 	}
 
 	SERVO::CVariable* pVariable = getVariable((int)SVID);
@@ -1785,12 +1854,168 @@
 	m_pPassive->sendMessage(pMessage);
 	LOGI("<HSMS>[SEND]sessionId:%d, sType:%d systemBytes:%d",
 		pMessage->getHeader()->sessionId, pMessage->getHeader()->sType, pMessage->getHeader()->systemBytes);
-	LOGI("<HSMS>[SEND]%s", pMessage->toString());
+	LogSecsMessageBrief("<HSMS>[SEND]", pMessage);
 	HSMS_Destroy1Message(pMessage);
 
 
 
 	return 0;
+}
+
+// S1F11
+int CHsmsPassive::replyStatusVariableNamelistRequest(IMessage* pRecv)
+{
+	if (m_pPassive == NULL || STATE::SELECTED != m_pPassive->getState()) {
+		return ER_NOTSELECT;
+	}
+
+	std::vector<unsigned short> reqIds;
+	ISECS2Item* pBody = pRecv->getBody();
+	if (pBody != nullptr && pBody->getType() == SITYPE::L) {
+		const int sz = pBody->getSubItemSize();
+		for (int i = 0; i < sz; ++i) {
+			unsigned short id = 0;
+			if (pBody->getSubItemU2(i, id)) {
+				reqIds.push_back(id);
+			}
+		}
+	}
+
+	// Build response list items: {L:3 SVID, SVNAME, UNITS}
+	std::vector<unsigned short> svids;
+	std::set<unsigned short> requested(reqIds.begin(), reqIds.end());
+	Lock();
+	if (reqIds.empty()) {
+		for (auto v : m_variabels) {
+			svids.push_back(static_cast<unsigned short>(v->getVarialbleId()));
+		}
+	}
+	else {
+		// include requested IDs (existing + unknown marker)
+		for (auto id : requested) {
+			svids.push_back(id);
+		}
+	}
+	Unlock();
+
+	IMessage* pMessage = NULL;
+	HSMS_Create1Message(pMessage, m_nSessionId, 1, 12, pRecv->getHeader()->systemBytes);
+	ASSERT(pMessage);
+
+	ISECS2Item* pList = pMessage->getBody(); // Body is L[n] of {SVID, SVNAME, UNITS}
+	for (auto id : svids) {
+		ISECS2Item* pEntry = pList->addItem();
+		pEntry->addU2Item(id, "SVID");
+		SERVO::CVariable* v = getVariable((int)id);
+		if (v != nullptr) {
+			pEntry->addItem(v->getName().c_str(), "SVNAME");
+			// Use remark as UNITS if provided; empty string if none.
+			pEntry->addItem(v->getRemark().c_str(), "UNITS");
+		}
+		else {
+			// Unknown SVID: A:0 for name/units
+			pEntry->addItem("", "SVNAME");
+			pEntry->addItem("", "UNITS");
+		}
+	}
+
+	m_pPassive->sendMessage(pMessage);
+	LOGI("<HSMS>[SEND]sessionId:%d, sType:%d systemBytes:%d",
+		pMessage->getHeader()->sessionId, pMessage->getHeader()->sType, pMessage->getHeader()->systemBytes);
+	LogSecsMessageBrief("<HSMS>[SEND]", pMessage);
+	HSMS_Destroy1Message(pMessage);
+
+	return ER_NOERROR;
+}
+
+// S1F23
+int CHsmsPassive::replyCollectionEventNamelistRequest(IMessage* pRecv)
+{
+	if (m_pPassive == NULL || STATE::SELECTED != m_pPassive->getState()) {
+		return ER_NOTSELECT;
+	}
+
+	std::vector<unsigned short> reqIds;
+	ISECS2Item* pBody = pRecv->getBody();
+	if (pBody != nullptr && pBody->getType() == SITYPE::L) {
+		const int sz = pBody->getSubItemSize();
+		for (int i = 0; i < sz; ++i) {
+			unsigned short id = 0;
+			if (pBody->getSubItemU2(i, id)) {
+				reqIds.push_back(id);
+			}
+		}
+	}
+
+	struct CEInfo {
+		unsigned short id{ 0 };
+		std::string name;
+		std::vector<unsigned short> vids;
+	};
+	std::vector<CEInfo> ceInfos;
+	{
+		Lock();
+		if (reqIds.empty()) {
+			for (auto e : m_collectionEvents) {
+				if (e == nullptr) continue;
+				CEInfo info;
+				info.id = static_cast<unsigned short>(e->getEventId());
+				info.name = e->getName();
+				std::set<unsigned short> vidSet;
+				for (auto rpt : e->getReports()) {
+					if (rpt == nullptr) continue;
+					for (auto vid : rpt->getVids()) {
+						vidSet.insert(static_cast<unsigned short>(vid));
+					}
+				}
+				info.vids.assign(vidSet.begin(), vidSet.end());
+				ceInfos.push_back(std::move(info));
+			}
+		}
+		else {
+			for (auto id : reqIds) {
+				CEInfo info;
+				info.id = id;
+				SERVO::CCollectionEvent* e = getEvent(id);
+				if (e != nullptr) {
+					info.name = e->getName();
+					std::set<unsigned short> vidSet;
+					for (auto rpt : e->getReports()) {
+						if (rpt == nullptr) continue;
+						for (auto vid : rpt->getVids()) {
+							vidSet.insert(static_cast<unsigned short>(vid));
+						}
+					}
+					info.vids.assign(vidSet.begin(), vidSet.end());
+				}
+				ceInfos.push_back(std::move(info));
+			}
+		}
+		Unlock();
+	}
+
+	IMessage* pMessage = NULL;
+	HSMS_Create1Message(pMessage, m_nSessionId, 1, 24, pRecv->getHeader()->systemBytes);
+	ASSERT(pMessage);
+
+	ISECS2Item* pList = pMessage->getBody(); // Body is L[n] of {CEID, CENAME, L[VIDs]}
+	for (const auto& info : ceInfos) {
+		ISECS2Item* pEntry = pList->addItem();
+		pEntry->addU2Item(info.id, "CEID");
+		pEntry->addItem(info.name.c_str(), "CENAME"); // empty if unknown
+		ISECS2Item* pVidList = pEntry->addItem();
+		for (auto vid : info.vids) {
+			pVidList->addU2Item(vid, "VID");
+		}
+	}
+
+	m_pPassive->sendMessage(pMessage);
+	LOGI("<HSMS>[SEND]sessionId:%d, sType:%d systemBytes:%d",
+		pMessage->getHeader()->sessionId, pMessage->getHeader()->sType, pMessage->getHeader()->systemBytes);
+	LogSecsMessageBrief("<HSMS>[SEND]", pMessage);
+	HSMS_Destroy1Message(pMessage);
+
+	return ER_NOERROR;
 }
 
 // S2F13
@@ -1836,7 +2061,7 @@
 	m_pPassive->sendMessage(pMessage);
 	LOGI("<HSMS>[SEND]sessionId:%d, sType:%d systemBytes:%d",
 		pMessage->getHeader()->sessionId, pMessage->getHeader()->sType, pMessage->getHeader()->systemBytes);
-	LOGI("<HSMS>[SEND]%s", pMessage->toString());
+	LogSecsMessageBrief("<HSMS>[SEND]", pMessage);
 	HSMS_Destroy1Message(pMessage);
 
 	return 0;
@@ -2200,6 +2425,13 @@
 		goto MYREPLY;
 	}
 
+	if (!isHostCommandAllowed()) {
+		CAACK = CAACK_5;
+		ERRCODE = CAACK_5;
+		strError = "rejected - ControlState not OnlineRemote";
+		goto MYREPLY;
+	}
+
 
 	ISECS2Item* pBody = pRecv->getBody();
 	if (pBody == nullptr || pBody->getType() != SITYPE::L) ER_PARAM_ERROR;
@@ -2230,7 +2462,7 @@
 	m_pPassive->sendMessage(pMessage);
 	LOGI("<HSMS>[SEND]sessionId:%d, sType:%d systemBytes:%d",
 		pMessage->getHeader()->sessionId, pMessage->getHeader()->sType, pMessage->getHeader()->systemBytes);
-	LOGI("<HSMS>[SEND]%s", pMessage->toString());
+	LogSecsMessageBrief("<HSMS>[SEND]", pMessage);
 	HSMS_Destroy1Message(pMessage);
 	
 	return 0;
@@ -2335,7 +2567,7 @@
 	m_pPassive->sendMessage(pMessage);
 	LOGI("<HSMS>[SEND]sessionId:%d, sType:%d systemBytes:%d",
 		pMessage->getHeader()->sessionId, pMessage->getHeader()->sType, pMessage->getHeader()->systemBytes);
-	LOGI("<HSMS>[SEND]%s", pMessage->toString());
+	LogSecsMessageBrief("<HSMS>[SEND]", pMessage);
 	HSMS_Destroy1Message(pMessage);
 
 	return 0;
@@ -2402,6 +2634,13 @@
 	ISECS2Item* pReplyItemAcks = pReply->getBody()->addItem();
 	ISECS2Item* pReplyItemAck = pReplyItemAcks->addU1Item(0, "OBJACK");
 	ISECS2Item* pReplyItemErrs = pReplyItemAcks->addItem();
+
+	if (!isHostCommandAllowed()) {
+		ISECS2Item* pItemError = pReplyItemErrs->addItem();
+		pItemError->addU4Item(2001, "ERRCODE");
+		pItemError->addItem("rejected - ControlState not OnlineRemote", "ERRTEXT");
+		goto MYREPLY;
+	}
 
 	// 褰撳墠鍙鐞嗙被鍚勪负ControlJob
 	if (_strcmpi(pszObjType, "ControlJob") == 0) {
@@ -2501,7 +2740,7 @@
 	m_pPassive->sendMessage(pReply);
 	LOGI("<HSMS>[SEND]sessionId:%d, sType:%d systemBytes:%d",
 		pReply->getHeader()->sessionId, pReply->getHeader()->sType, pReply->getHeader()->systemBytes);
-	LOGI("<HSMS>[SEND]%s", pReply->toString());
+	LogSecsMessageBrief("<HSMS>[SEND]", pReply);
 	HSMS_Destroy1Message(pReply);
 
 
@@ -2516,6 +2755,25 @@
 	}
 	ISECS2Item* pBody = pRecv->getBody();
 	if (pBody == nullptr || pBody->getType() != SITYPE::L) ER_PARAM_ERROR;
+
+	if (!isHostCommandAllowed()) {
+		IMessage* pMessage = NULL;
+		HSMS_Create1Message(pMessage, m_nSessionId, 16, 16, ++m_nSystemByte);
+		ASSERT(pMessage);
+		ISECS2Item* pItemPrjobIds = pMessage->getBody()->addItem();
+		ISECS2Item* pItemErrors = pMessage->getBody()->addItem();
+		pItemErrors->addBoolItem(false, "ACKA");
+		ISECS2Item* pItemErrors2 = pItemErrors->addItem();
+		auto err = pItemErrors2->addItem();
+		err->addU4Item(2001, "ERRCODE");
+		err->addItem("rejected - ControlState not OnlineRemote", "ERRTEXT");
+		m_pPassive->sendMessage(pMessage);
+		LOGI("<HSMS>[SEND]sessionId:%d, sType:%d systemBytes:%d",
+			pMessage->getHeader()->sessionId, pMessage->getHeader()->sType, pMessage->getHeader()->systemBytes);
+		LogSecsMessageBrief("<HSMS>[SEND]", pMessage);
+		HSMS_Destroy1Message(pMessage);
+		return 0;
+	}
 
 
 	// 瑙i噴鏁版嵁锛屽緱鍒癈ProcessJob
@@ -2569,9 +2827,6 @@
 		pjs.push_back(pj);
 	}
 
-	ASSERT(m_listener.onPRJobMultiCreate != nullptr);
-	int nRet = m_listener.onPRJobMultiCreate(this, pjs);
-
 
 	// 鍥炲鎶ユ枃
 	IMessage* pMessage = NULL;
@@ -2602,8 +2857,12 @@
 	m_pPassive->sendMessage(pMessage);
 	LOGI("<HSMS>[SEND]sessionId:%d, sType:%d systemBytes:%d",
 		pMessage->getHeader()->sessionId, pMessage->getHeader()->sType, pMessage->getHeader()->systemBytes);
-	LOGI("<HSMS>[SEND]%s", pMessage->toString());
+	LogSecsMessageBrief("<HSMS>[SEND]", pMessage);
 	HSMS_Destroy1Message(pMessage);
+
+
+	ASSERT(m_listener.onPRJobMultiCreate != nullptr);
+	int nRet = m_listener.onPRJobMultiCreate(this, pjs);
 
 
 	// 閲婃斁鏈夐棶棰�(鏈坊鍔犲埌master)鐨勫唴瀛�
@@ -2670,7 +2929,15 @@
 	ISECS2Item* pItem = pMessage->getBody();
 	// pItem->addU2Item(++DATAID, "DATAID");		// 鏍规嵁鍒殑鏃ュ織鏄剧ずDATAID鎭掍负0锛屾墍浠ユ垜浠厛鐓т娇鐢�0
 	pItem->addU2Item(0, "DATAID");
-	pItem->addU4Item(CEID, "CEID");
+	std::string ceidNote("CEID");
+	if (pEvent != nullptr) {
+		auto& name = pEvent->getName();
+		if (!name.empty()) {
+			ceidNote += " -> ";
+			ceidNote += name;
+		}
+	}
+	pItem->addU4Item(CEID, ceidNote.c_str());
 	ISECS2Item* pItemList1 = pItem->addItem(); // L[n] reports
 	if (pReport != nullptr) {
 		ISECS2Item* pItemList2 = pItemList1->addItem();

--
Gitblit v1.9.3